Re: [PATCH v3 1/3] kernfs: remove page_mkwrite() from vm_operations_struct

[Martin Oliveira]

On 2024-07-05 01:20, Christoph Hellwig wrote:
> Btw, sorry if I mislead you with my WARN_ON_ONCE suggestion.  That
> was always intended in addition to the error handling, not instead.
> (In fact there are very few reasons to use WARN_ON* without actually
> handling the error as well).

Yeah, I should have caught that. Thanks for the feedback, Christoph!
I'll submit a new version later today.
  
> Yes, doing the same for ->close or anything unimplemented would be
> nice.  But it's not really in scope for this series.
> 
> kernfs really should be using it's own ops instead of abusing
> file_operations, but that's even more out of scope..

Ok, I'll add the ->page_mkwrite with the WARN but leave the ->close
the way it is.

Martin