Re: [PATCH v7 5/6] KVM: arm64: Initialize the ptdump parser with stage-2 attributes

[Oliver Upton]

On Mon, Jul 01, 2024 at 02:17:53PM +0000, Sebastian Ene wrote:
> > <snip>
> > 
> > > +	}, {
> > > +		.mask	= PTE_NG,
> > > +		.val	= PTE_NG,
> > > +		.set	= "FnXS",
> > > +		.clear	= "  ",
> > > +	}, {
> > > +		.mask	= PTE_CONT | PTE_VALID,
> > > +		.val	= PTE_CONT | PTE_VALID,
> > > +		.set	= "CON",
> > > +		.clear	= "   ",
> > > +	}, {
> > 
> > </snip>
> > 
> > Neither of these bits are used at stage-2, why have descriptors for
> > them?
> > 
> 
> Atm, we don't make use of the contiguous bit in stage-2 in upstream (but
> we have it in some experimental patches). I can remove this, no hard
> feelings for them.

Yes, please drop them. I'll nag whoever adds contpte support for stage-2
to add them back :)

-- 
Thanks,
Oliver