Re: [PATCH v2 2/2] sched_ext: Add cpuperf support

From: Vincent Guittot
Date: Mon Jul 08 2024 - 15:51:30 EST


On Mon, 8 Jul 2024 at 20:20, Tejun Heo <tj@xxxxxxxxxx> wrote:
>
> Hello, Vincent.
>
> On Mon, Jul 08, 2024 at 08:37:06AM +0200, Vincent Guittot wrote:
> > I prefer to minimize (if not remove) sched_ext related calls in the
> > fair path so we can easily rework it if needed. And this will also
> > ensure that all fair task are cleanly removed when they are all
> > switched to sched_ext
>
> Unless we add a WARN_ON_ONCE, if it doesn't behave as expected, the end
> result will most likely be cpufreq sometimes picking a higher freq than
> requested, which won't be the easiest to notice. Would you be against adding
> WARN_ON_ONCE(scx_switched_all && !util) too?

A WARN_ON_ONCE to detect misbehavior would be ok

>
> Thanks.
>
> --
> tejun