[PATCH v2 1/2] firmware_loader: annotate doctests as `no_run`
From: Danilo Krummrich
Date: Mon Jul 08 2024 - 16:07:42 EST
The doctests of `Firmware` are compile-time only tests, since they
require a proper `Device` and a valid path to a (firmware) blob in order
to do something sane on runtime - we can't satisfy both of those
requirements.
Hence, configure the example as `no_run`.
Unfortunately, the kernel's Rust build system can't consider the
`no_run` attribute yet. Hence, for the meantime, wrap the example code
into a new function and never actually call it.
Fixes: de6582833db0 ("rust: add firmware abstractions")
Signed-off-by: Danilo Krummrich <dakr@xxxxxxxxxx>
---
v2: (no changes)
---
rust/kernel/firmware.rs | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/rust/kernel/firmware.rs b/rust/kernel/firmware.rs
index 386c8fb44785..106a928a535e 100644
--- a/rust/kernel/firmware.rs
+++ b/rust/kernel/firmware.rs
@@ -26,14 +26,18 @@
///
/// # Examples
///
-/// ```
+/// ```no_run
/// # use kernel::{c_str, device::Device, firmware::Firmware};
///
+/// # fn no_run() -> Result<(), Error> {
/// # // SAFETY: *NOT* safe, just for the example to get an `ARef<Device>` instance
/// # let dev = unsafe { Device::from_raw(core::ptr::null_mut()) };
///
-/// let fw = Firmware::request(c_str!("path/to/firmware.bin"), &dev).unwrap();
+/// let fw = Firmware::request(c_str!("path/to/firmware.bin"), &dev)?;
/// let blob = fw.data();
+///
+/// # Ok(())
+/// # }
/// ```
pub struct Firmware(NonNull<bindings::firmware>);
base-commit: 997197b58bf6e22b8c6ef88a168d8292fa9acec9
--
2.45.2