Re: [PATCH v4 1/2] dt-bindings: mmc: nuvoton,ma35d1-sdhci: Document MA35D1 SDHCI controller

[Shan-Chun Hung]

Dear Krzysztof,

Thank you for your review.

I will make sure to keep the same order as in the list of properties.

I'm sorry if I missed your comments before.

I will do my best to address them in the future.

Thanks for your understanding.


Best Regards

Shan-Chun


On 2024/7/8 下午 10:19, Krzysztof Kozlowski wrote:
> On 04/07/2024 08:26, Shan-Chun Hung wrote:
> > Add binding for Nuvoton MA35D1 SDHCI controller.
> >
> > Signed-off-by: Shan-Chun Hung <shanchun1218@xxxxxxxxx>
> > ---
>
> > +
> > +  nuvoton,sys:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: phandle to access GCR (Global Control Register) registers.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - pinctrl-names
> > +  - pinctrl-0
> > +  - resets
> > +  - nuvoton,sys
> Keep the same order as in list of properties.
>
> Normally I would give conditional review tag, but not that case because
> in the past you kept ignoring review comments.
>
> Best regards,
> Krzysztof