Re: [PATCH 6/8] firmware: arm_scmi: Make OPTEE transport a standalone driver

From: Dan Carpenter
Date: Mon Jul 08 2024 - 22:21:57 EST


On Sun, Jul 07, 2024 at 01:20:53AM +0100, Cristian Marussi wrote:
> static int scmi_optee_service_probe(struct device *dev)
> {
> struct scmi_optee_agent *agent;
> @@ -555,7 +553,7 @@ static int scmi_optee_service_probe(struct device *dev)
> smp_mb();
> scmi_optee_private = agent;
>
> - return 0;
> + return platform_driver_register(&scmi_optee_driver);

There needs to be some cleanup if platform_driver_register() fails.

>
> err:
> tee_client_close_context(tee_ctx);

regards,
dan carpenter