Re: [PATCH] vdpa/mlx5: Add the support of set mac address

From: Ratheesh Kannoth
Date: Tue Jul 09 2024 - 00:56:41 EST


On 2024-07-08 at 12:25:49, Cindy Lu (lulu@xxxxxxxxxx) wrote:
> +static int mlx5_vdpa_set_attr_mac(struct vdpa_mgmt_dev *v_mdev,
> + struct vdpa_device *dev,
> + const struct vdpa_dev_set_config *add_config)
> +{
> + struct mlx5_vdpa_dev *mvdev = to_mvdev(dev);
> + struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);
> + struct mlx5_core_dev *mdev = mvdev->mdev;
> + struct virtio_net_config *config = &ndev->config;
> + int err;
> + struct mlx5_core_dev *pfmdev;
nit: reverse xmas tree; may be, split assigment and definition.

>