Re: [PATCH] x86/tdx: Support vmalloc() for tdx_enc_status_changed()

[Jiri Slaby]

On 08. 07. 24, 23:45, Dexuan Cui wrote:
> > From: Borislav Petkov <bp@xxxxxxxxx>
> > > Cc: stable@xxxxxxxxxxxxxxx
> >
> > Why?
> >
> > Fixes: what?
>
> Please refer to my reply above.
>
> This is not to fix a buggy commit. The described scenario never worked before,
> so I suppose a "Fixes:" tag is not needed.

If you cc stable, fixes *is* actually needed. So again, why to cc stable 
when this is a feature? I suppose you will receive a Greg-bot reply 
anyway ;).

> >  From reading this, it seems to me you need to brush up on
> > https://kernel.org/doc/html/latest/process/submitting-patches.html
> Thanks for the link! I read it and did learn something.
>
> > while waiting.
...> I hope I have provided a satisfactory reply above.
> How do you like the v12 below? It's also attached.
> If this looks good to you, I can post it today or tomorrow.

Then you need to enumerate what changed in v1..v12. In every single 
revision. Do it under the "---" line below. And add v12 to the subject 
as you did below (but not above).

>  From 132f656fdbf3b4f00752140aac10f3674b598b5a Mon Sep 17 00:00:00 2001
> From: Dexuan Cui <decui@xxxxxxxxxxxxx>
> Date: Mon, 20 May 2024 19:12:38 -0700
> Subject: [PATCH v12] x86/tdx: Fix set_memory_decrypted() for vmalloc() buffers
...
> hv_netvsc is the first user of vmalloc() + set_memory_decrypted(), which
> is why nobody noticed this until now.
>
> Co-developed-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
> Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>
> Reviewed-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Acked-by: Kai Huang <kai.huang@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # 6.6+
> ---

The revision log belongs here. I believe you had to meet that 
requirement in the submittingpatches document.

And to avoid future confusion, I would list the links to received 
"Signed-off-by"/"Reviewed-by"s here too. The links you listed earlier.

>   arch/x86/coco/tdx/tdx.c | 43 ++++++++++++++++++++++++++++++++++-------
>   1 file changed, 36 insertions(+), 7 deletions(-)

regards,
--
js
suse labs