Re: [PATCH v11 3/6] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver

From: Markus Elfring
Date: Tue Jul 09 2024 - 03:48:35 EST



> +++ b/drivers/media/platform/toshiba/visconti/viif_capture.c
> @@ -0,0 +1,1431 @@

> +static int viif_set_img(struct cap_dev *cap_dev, struct vb2_buffer *vb)
> +{

> + if (cap_dev->pathid == CAPTURE_PATH_MAIN_POST0) {
> + spin_lock(&viif_dev->regbuf_lock);
> + hwd_viif_isp_guard_start(viif_dev);

> + hwd_viif_isp_guard_end(viif_dev);
> + spin_unlock(&viif_dev->regbuf_lock);


Under which circumstances would you become interested to apply a statement
like “guard(spinlock)(&viif_dev->regbuf_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/spinlock.h#L561

Regards,
Markus