Re: [PATCH v4 02/14] MIPS: GIC: Generate redirect block accessors

From: Thomas Bogendoerfer
Date: Tue Jul 09 2024 - 04:56:40 EST


On Sat, May 11, 2024 at 12:43:29PM +0200, Aleksandar Rikalo wrote:
> From: Paul Burton <paulburton@xxxxxxxxxx>
>
> With CM 3.5 the "core-other" register block evolves into the "redirect"
> register block, which is capable of accessing not only the core local
> registers of other cores but also the shared/global registers of other
> clusters.
>
> This patch generates accessor functions for shared/global registers
> accessed via the redirect block, with "redir_" inserted after "gic_" in
> their names. For example the accessor function:
>
> read_gic_config()
>
> ...accesses the GIC_CONFIG register of the GIC in the local cluster.
> With this patch a new function:
>
> read_gic_redir_config()
>
> ...is added which accesses the GIC_CONFIG register of the GIC in
> whichever cluster the GCR_CL_REDIRECT register is configured to access.
>
> This mirrors the similar redirect block accessors already provided for
> the CM & CPC.
>
> Reviewed-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
> Signed-off-by: Paul Burton <paulburton@xxxxxxxxxx>
> Signed-off-by: Chao-ying Fu <cfu@xxxxxxxxxxxx>
> Signed-off-by: Dragan Mladjenovic <dragan.mladjenovic@xxxxxxxxxx>
> Signed-off-by: Aleksandar Rikalo <aleksandar.rikalo@xxxxxxxxxx>
> ---
> arch/mips/include/asm/mips-gic.h | 50 ++++++++++++++++++++++----------
> 1 file changed, 34 insertions(+), 16 deletions(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]