Re: [PATCH v2 4/6] dt-bindings: clock: qcom: Add SM8150 camera clock controller

[Satya Priya Kakitapalli (Temp)]

On 7/3/2024 3:44 PM, Dmitry Baryshkov wrote:
> On Tue, Jul 02, 2024 at 09:20:42PM GMT, Satya Priya Kakitapalli wrote:
> > Add device tree bindings for the camera clock controller on
> > Qualcomm SM8150 platform.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx>
> > ---
> >   .../bindings/clock/qcom,sm8150-camcc.yaml          |  77 ++++++++++++
> >   include/dt-bindings/clock/qcom,sm8150-camcc.h      | 135 +++++++++++++++++++++
> >   2 files changed, 212 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8150-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8150-camcc.yaml
> > new file mode 100644
> > index 000000000000..8fc27ba4be4b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8150-camcc.yaml
> > @@ -0,0 +1,77 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/qcom,sm8150-camcc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Camera Clock & Reset Controller on SM8150
> > +
> > +maintainers:
> > +  - Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx>
> > +
> > +description: |
> > +  Qualcomm camera clock control module provides the clocks, resets and
> > +  power domains on SM8150.
> > +
> > +  See also:: include/dt-bindings/clock/qcom,sm8150-camcc.h
> > +
> > +properties:
> > +  compatible:
> > +    const: qcom,sm8150-camcc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    items:
> > +      - description: Board XO source
> > +      - description: Camera AHB clock from GCC
> No sleep clock?


No, for sm8150 there is no need of sleep clock. It is not used for any 
of the camcc clocks.