Re: [PATCH V7 0/5] Add control for switching back and forth to HW control

[Ulf Hansson]

On Wed, 3 Jul 2024 at 05:11, Bjorn Andersson <andersson@xxxxxxxxxx> wrote:
>
> On Mon, Jun 24, 2024 at 10:18:04AM GMT, Jagadeesh Kona wrote:
> > This series adds support for dev_pm_genpd_set_hwmode() and dev_pm_genpd_get_hwmode() APIs
> > and support in gdsc genpd provider drivers to register respective callbacks and a venus
> > consumer driver example using above API to switch the power domain(GDSC) to HW/SW modes
> > dynamically at runtime.
> >
>
> Ulf, I discussed the concerns I had with Taniya and I think this looks
> good. Please pick the gdsc/clock patches through the pmdomain tree.
>
> Regards,
> Bjorn

The series applied for next, thanks!

Kind regards
Uffe


>
> > Changes in V7:
> > - [PATCH 3/5]: Updated the comment description in gdsc_set_hwmode as per V6 review comments
> > - Added R-By tags received on V6
> > - Link to V6: https://lore.kernel.org/all/20240619141413.7983-1-quic_jkona@xxxxxxxxxxx/
> >
> > Changes in V6:
> > - [PATCH 3/5]: Added details for 1usec delay in gdsc_set_hwmode()
> > - [PATCH 4/5]: Updated commit text
> > - Added R-By and T-By tags received on V5 RESEND
> > - Link to V5 RESEND: https://lore.kernel.org/all/20240413152013.22307-1-quic_jkona@xxxxxxxxxxx/
> > - Link to V5: https://lore.kernel.org/all/20240315111046.22136-1-quic_jkona@xxxxxxxxxxx/
> >
> > Changes in V5:
> > - Updated 1st patch as per V4 review comments to synchronize the initial HW mode state by
> >   invoking ->get_hwmode_dev()callback in genpd_add_device()
> > - With above change, SW cached hwmode will contain correct value initially, and it will be
> >   updated everytime mode is changed in set_hwmode, hence updated dev_pm_genpd_get_hwmode()
> >   to just return SW cached hwmode in 1st patch
> > - Updated commit text for 1st, 3rd, 4th and 5th patches
> > - Updated 3rd and 5th patches as per review comments received on V4 series
> > - Added R-By tags received in older series to 1st and 2nd patches
> > - Link to V4: https://lore.kernel.org/all/20240122-gdsc-hwctrl-v4-0-9061e8a7aa07@xxxxxxxxxx/
> >
> > Changes in V4:
> >  - Re-worded 1st patch commit message, as per Bjorn's suggestion, and added
> >    Dmitry's R-b tag
> >  - Added Bjorn's and Dmitry's R-b tags to the 2nd patch
> >  - Re-worded 3rd patch commit message, to better explain the HW_CTRL_TRIGGER flag.
> >  - Added mode transition delay when setting mode for GDSC
> >  - Added status polling if GDSSC is enabled when transitioning from HW to SW
> >  - Re-worded 4th patch commit message to better explain why the
> >    HW_CTRL_TRIGGER needs to be used instead
> >  - Drop changes to SC7180, SDM845 and SM8550 video CC drivers, as only
> >    SC7280 and SM8250 have been tested so far. More platforms (with v6 venus)
> >    will be added eventually.
> >  - Call genpd set_hwmode API only for v6 and dropped the vcodec_pmdomains_hwctrl.
> >  - Re-worded 5th patch commit message accordingly.
> >  - Link to V3: https://lore.kernel.org/lkml/20230823114528.3677667-1-abel.vesa@xxxxxxxxxx/
> >
> > Changes in V3:
> >  - 5th patch has been squashed in the 4th one
> >  - Link to V2: https://lore.kernel.org/lkml/20230816145741.1472721-1-abel.vesa@xxxxxxxxxx/
> >
> > Changes in V2:
> >  - patch for printing domain HW-managed mode in the summary
> >  - patch that adds one consumer (venus)
> >  - patch for gdsc with new (different) flag
> >  - patch for videocc GDSC provider to update flags
> >  - Link to V1: https://lore.kernel.org/all/20230628105652.1670316-1-abel.vesa@xxxxxxxxxx/
> >
> > Abel Vesa (1):
> >   PM: domains: Add the domain HW-managed mode to the summary
> >
> > Jagadeesh Kona (3):
> >   clk: qcom: gdsc: Add set and get hwmode callbacks to switch GDSC mode
> >   clk: qcom: videocc: Use HW_CTRL_TRIGGER for SM8250, SC7280 vcodec
> >     GDSC's
> >   venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on
> >     V6
> >
> > Ulf Hansson (1):
> >   PM: domains: Allow devices attached to genpd to be managed by HW
> >
> >  drivers/clk/qcom/gdsc.c                       | 41 ++++++++++
> >  drivers/clk/qcom/gdsc.h                       |  1 +
> >  drivers/clk/qcom/videocc-sc7280.c             |  2 +-
> >  drivers/clk/qcom/videocc-sm8250.c             |  4 +-
> >  .../media/platform/qcom/venus/pm_helpers.c    | 39 ++++++----
> >  drivers/pmdomain/core.c                       | 78 ++++++++++++++++++-
> >  include/linux/pm_domain.h                     | 17 ++++
> >  7 files changed, 161 insertions(+), 21 deletions(-)
> >
> > --
> > 2.43.0
> >