Re: [PATCH v2 10/13] xfs: Unmap blocks according to forcealign

From: Christoph Hellwig
Date: Tue Jul 09 2024 - 07:21:06 EST


On Tue, Jul 09, 2024 at 07:57:22PM +1000, Dave Chinner wrote:
> No code should be doing "if (forcealign) ... else if (realtime) ..."
> branching for alignment purposes. All the code should all be
> generic based on the value xfs_inode_alloc_unitsize() returns.

Yes, please.