Re: [PATCH v2 2/6] Bluetooth: hci_qca: schedule a devm action for disabling the clock
From: Bartosz Golaszewski
Date: Tue Jul 09 2024 - 07:24:30 EST
On Tue, Jul 9, 2024 at 12:34 PM kernel test robot <lkp@xxxxxxxxx> wrote:
>
> Hi Bartosz,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on 0b58e108042b0ed28a71cd7edf5175999955b233]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Bartosz-Golaszewski/dt-bindings-bluetooth-qualcomm-describe-the-inputs-from-PMU-for-wcn7850/20240708-175040
> base: 0b58e108042b0ed28a71cd7edf5175999955b233
> patch link: https://lore.kernel.org/r/20240708-hci_qca_refactor-v2-2-b6e83b3d1ca5%40linaro.org
> patch subject: [PATCH v2 2/6] Bluetooth: hci_qca: schedule a devm action for disabling the clock
> config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240709/202407091813.9IlBCkUP-lkp@xxxxxxxxx/config)
> compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240709/202407091813.9IlBCkUP-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202407091813.9IlBCkUP-lkp@xxxxxxxxx/
>
> All warnings (new ones prefixed by >>):
>
> drivers/bluetooth/hci_qca.c:2495:2: warning: label at end of compound statement is a C23 extension [-Wc23-extensions]
> 2495 | }
> | ^
> >> drivers/bluetooth/hci_qca.c:2494:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
> 2494 | default:
> | ^
> drivers/bluetooth/hci_qca.c:2494:2: note: insert '__attribute__((fallthrough));' to silence this warning
> 2494 | default:
> | ^
> | __attribute__((fallthrough));
> drivers/bluetooth/hci_qca.c:2494:2: note: insert 'break;' to avoid fall-through
> 2494 | default:
> | ^
> | break;
> 2 warnings generated.
>
>
> vim +2494 drivers/bluetooth/hci_qca.c
>
> 05ba533c5c1155 Thierry Escande 2018-03-29 2478
> 05ba533c5c1155 Thierry Escande 2018-03-29 2479 static void qca_serdev_remove(struct serdev_device *serdev)
> 05ba533c5c1155 Thierry Escande 2018-03-29 2480 {
> 05ba533c5c1155 Thierry Escande 2018-03-29 2481 struct qca_serdev *qcadev = serdev_device_get_drvdata(serdev);
> 054ec5e94a46b0 Venkata Lakshmi Narayana Gubba 2020-09-10 2482 struct qca_power *power = qcadev->bt_power;
> 05ba533c5c1155 Thierry Escande 2018-03-29 2483
> 691d54d0f7cb14 Neil Armstrong 2023-08-16 2484 switch (qcadev->btsoc_type) {
> 691d54d0f7cb14 Neil Armstrong 2023-08-16 2485 case QCA_WCN3988:
> 691d54d0f7cb14 Neil Armstrong 2023-08-16 2486 case QCA_WCN3990:
> 691d54d0f7cb14 Neil Armstrong 2023-08-16 2487 case QCA_WCN3991:
> 691d54d0f7cb14 Neil Armstrong 2023-08-16 2488 case QCA_WCN3998:
> 691d54d0f7cb14 Neil Armstrong 2023-08-16 2489 case QCA_WCN6750:
> 691d54d0f7cb14 Neil Armstrong 2023-08-16 2490 case QCA_WCN6855:
> e0c1278ac89b03 Neil Armstrong 2023-08-16 2491 case QCA_WCN7850:
> d12f113a15e826 Bartosz Golaszewski 2024-07-08 2492 if (power->vregs_on)
> c2d7827338618a Balakrishna Godavarthi 2018-08-22 2493 qca_power_shutdown(&qcadev->serdev_hu);
> 691d54d0f7cb14 Neil Armstrong 2023-08-16 @2494 default:
> 691d54d0f7cb14 Neil Armstrong 2023-08-16 @2495 }
> fa9ad876b8e0eb Balakrishna Godavarthi 2018-08-03 2496
> fa9ad876b8e0eb Balakrishna Godavarthi 2018-08-03 2497 hci_uart_unregister_device(&qcadev->serdev_hu);
> 05ba533c5c1155 Thierry Escande 2018-03-29 2498 }
> 05ba533c5c1155 Thierry Escande 2018-03-29 2499
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
Ah, cr*p.
Third time's the charm, I guess...
Bart