Re: [PATCH v17] arm64: dts: qcom: sa8295p-adp: Enable the four USB Type-A ports

[Konrad Dybcio]

On 7.07.2024 10:56 AM, Krishna Kurapati wrote:
> The multiport USB controller in the SA8295P ADP is connected to four USB
> Type-A ports. VBUS for each of these ports are provided by a
> TPS2559QWDRCTQ1 regulator, controlled from PMIC GPIOs.
> 
> Add the necessary regulators and GPIO configuration to power these.
> 
> It seems reasonable that these regulators should be referenced as vbus
> supply of usb-a-connector nodes and controlled by e.g. dwc3, but as this
> is not supported in Linux today the regulators are left always-on for
> now.
> 
> Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx>
> ---

Looks reasonable, thanks for taking this all the way through the review
process!


Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad