Re: [PATCH] sched/fair: Remove stale buddies comment for last and skip

[Vincent Guittot]

On Sat, 6 Jul 2024 at 11:10, Bing Huang <huangbing775@xxxxxxx> wrote:
>
> From: Bing Huang <huangbing@xxxxxxxxxx>
>
> commit 5e963f2bd465 ("sched/fair: Commit to EEVDF") has removed last and
> skip. Modify the comment accordingly.
>
> Signed-off-by: Bing Huang <huangbing@xxxxxxxxxx>

Acked-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>

> ---
>  kernel/sched/fair.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 41b58387023d..383582f87def 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5466,8 +5466,6 @@ set_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
>   * Pick the next process, keeping these things in mind, in this order:
>   * 1) keep things fair between processes/task groups
>   * 2) pick the "next" process, since someone really wants that to run
> - * 3) pick the "last" process, for cache locality
> - * 4) do not run the "skip" process, if something else is available
>   */
>  static struct sched_entity *
>  pick_next_entity(struct cfs_rq *cfs_rq)
> --
> 2.25.1
>