[PATCH AUTOSEL 5.4 05/11] can: kvaser_usb: fix return value for hif_usb_send_regout

From: Sasha Levin
Date: Tue Jul 09 2024 - 12:56:35 EST


From: Chen Ni <nichen@xxxxxxxxxxx>

[ Upstream commit 0d34d8163fd87978a6abd792e2d8ad849f4c3d57 ]

As the potential failure of usb_submit_urb(), it should be better to
return the err variable to catch the error.

Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
Link: https://lore.kernel.org/all/20240521041020.1519416-1-nichen@xxxxxxxxxxx
Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
---
drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
index 1f015b496a472..a26103727fc3e 100644
--- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
+++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
@@ -265,7 +265,7 @@ int kvaser_usb_send_cmd_async(struct kvaser_usb_net_priv *priv, void *cmd,
}
usb_free_urb(urb);

- return 0;
+ return err;
}

int kvaser_usb_can_rx_over_error(struct net_device *netdev)
--
2.43.0