RE: [PATCH net v3 1/1] ethtool: netlink: do not return SQI value if link is down

[Woojung.Huh]

> -----Original Message-----
> From: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> Sent: Tuesday, July 9, 2024 2:20 AM
> To: Michal Kubecek <mkubecek@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>;
> Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; Jiri Pirko <jiri@xxxxxxxxxxx>; Vladimir Oltean
> <vladimir.oltean@xxxxxxx>; Andrew Lunn <andrew@xxxxxxx>; Arun Ramadoss -
> I17769 <Arun.Ramadoss@xxxxxxxxxxxxx>; Woojung Huh - C21699
> <Woojung.Huh@xxxxxxxxxxxxx>
> Cc: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>; kernel@xxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; UNGLinuxDriver <UNGLinuxDriver@xxxxxxxxxxxxx>;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH net v3 1/1] ethtool: netlink: do not return SQI value if
> link is down
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Do not attach SQI value if link is down. "SQI values are only valid if
> link-up condition is present" per OpenAlliance specification of
> 100Base-T1 Interoperability Test suite [1]. The same rule would apply
> for other link types.
> 
> [1] https://opensig.org/automotive-ethernet-specifications/#
> 
> Fixes: 806602191592 ("ethtool: provide UAPI for PHY Signal Quality Index
> (SQI)")
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> ---

Reviewed-by: Woojung Huh <woojung.huh@xxxxxxxxxxxxx>

Thanks.
Woojung