Re: [PATCH v2] mailbox: mtk-cmdq: add missing MODULE_DESCRIPTION() macro
From: Jeff Johnson
Date: Tue Jul 09 2024 - 16:18:59 EST
On 6/24/2024 9:09 AM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mailbox/mtk-cmdq-mailbox.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> ---
> Changes in v2:
> - Updated description per AngeloGioacchino Del Regno and propaged the
> Reviewed-by tag
> - Link to v1: https://lore.kernel.org/r/20240608-md-drivers-mailbox-v1-1-6ce5d6f924ad@xxxxxxxxxxx
> ---
> drivers/mailbox/mtk-cmdq-mailbox.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index 4aa394e91109..71eb78c3d6ce 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -790,4 +790,5 @@ static void __exit cmdq_drv_exit(void)
> subsys_initcall(cmdq_drv_init);
> module_exit(cmdq_drv_exit);
>
> +MODULE_DESCRIPTION("Mediatek Command Queue(CMDQ) Mailbox driver");
> MODULE_LICENSE("GPL v2");
>
> ---
> base-commit: 19ca0d8a433ff37018f9429f7e7739e9f3d3d2b4
> change-id: 20240608-md-drivers-mailbox-3cd31fdfc4b6
I don't see this in linux-next yet so following up to see if anything else is
needed to get this merged.