RE: [PATCH v11 0/2] wifi: mwifiex: add code to support host mlme

[David Lin]

Hi Kalle,

I found the state of this patch series had been changed to "Deferred".

Since this patch series had been reviewed for a long period of time and
reviewed, tested, and acked by members from community. I wonder what
else should I do to let it be merged to mainline Linux kernel?

David

> From: David Lin <yu-hao.lin@xxxxxxx>
> Sent: Thursday, July 4, 2024 11:30 AM
> To: linux-wireless@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; briannorris@xxxxxxxxxxxx;
> kvalo@xxxxxxxxxx; francesco@xxxxxxxxxx; Pete Hsieh
> <tsung-hsien.hsieh@xxxxxxx>; David Lin <yu-hao.lin@xxxxxxx>; Rafael Beims
> <rafael.beims@xxxxxxxxxxx>; Francesco Dolcini
> <francesco.dolcini@xxxxxxxxxxx>
> Subject: [PATCH v11 0/2] wifi: mwifiex: add code to support host mlme
> 
> With host mlme:
> Tested-by: <rafael.beims@xxxxxxxxxxx> #Verdin AM62 IW416 SD Without host
> mlme:
> Tested-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> # 88W8997-SD
> 
> This series add host based MLME support to the mwifiex driver, this enables
> WPA3 support in both client and AP mode.
> To enable WPA3, a firmware with corresponding V2 Key API support is
> required.
> The feature is currently only enabled on NXP IW416 (SD8978), and it was
> internally validated by NXP QA team. Other NXP Wi-Fi chips supported in
> current mwifiex are not affected by this change.
> 
> v11:
>    - add proper and useful comment for mwifiex_cfg80211_probe_client().
>    - modify 'mwifiex_mgmt_stypes' to allow multi-adapters with different
>      setting of host_mlme_enbaled.
> 
> v10:
>    - Use eth_broadcast_addr() to set the broadcast address.
>    - Add comment for constant used for the length of FW special 4 address
>      management header.
>    - Check host_mlme_enabled to decide if creating host_mlme_workqueue
>      or not.
>    - Use cpu_to_le16 instead of casting via (__force __le16).
>    - Change the abbreviation "disasso" to "disassoc" of the printout message.
> 
> v9:
>    - Remove redundent code.
>    - Remove unnecessary goto target.
> 
> v8:
>    - Separate 6/12 from patch v7.
>      As it's a bug fix not part of host MLME feature.
>    - Rearrnage MLME feature into 2 patches:
>      a. Add host based MLME support for STA mode.
>      b. Add host based MLME support for AP mode.
> 
> v7:
>    - Fix regression: Downlink throughput degraded by 70% in AP mode.
>    - Fix issue: On STAUT, kernel Oops occurs when there is no association
>      response from AP.
>    - Fix issue: On STAUT, if AP leaves abruptly and deauth is missing,
>      STA can't connect to AP anymore.
>    - Fix regression: STA can't connect to AP when host_mlme is disabled
>      (impact all chips).
>    - Address reviewer comments.
> 
> v6:
>    - Correct mailing sequence.
> 
> v5:
>    - Add host base MLME support to enable WPA3 functionalities for both
>      STA and AP mode.
>    - This feature (WPA3) required a firmware with corresponding Key API V2
>      support.
>    - QA validation and regression have been covered for IW416.
>    - This feature (WPA3) is currently enabled and verified only for IW416.
>    - Changelogs since patch V4:
>      a. Add WPA3 support for AP mode.
>      b. Bug fix: In WPA3 STA mode, deice gets disconnected from AP
>         when group rekey occurs.
>      c. Bug fix: STAUT doesn't send WMM IE in association request when
>         associate to a WMM-AP.
> 
> v4:
>    - Refine code segment per review comment.
>    - Add API to check firmware encryption key command version when
>      host_mlme is enabled.
> 
> v3:
>    - Cleanup commit message.
> 
> v2:
>    - Fix checkpatch error (pwe[1] -> pwe[0]).
>    - Move module parameter 'host_mlme' to mwifiex_sdio_device structure.
>      Default only enable for IW416.
>    - Disable advertising NL80211_FEATURE_SAE if host_mlme is not enabled.
> 
> David Lin (2):
>   wifi: mwifiex: add host mlme for client mode
>   wifi: mwifiex: add host mlme for AP mode
> 
>  .../net/wireless/marvell/mwifiex/cfg80211.c   | 404 +++++++++++++++++-
>  drivers/net/wireless/marvell/mwifiex/cmdevt.c |  27 ++
>  drivers/net/wireless/marvell/mwifiex/decl.h   |  23 +
>  drivers/net/wireless/marvell/mwifiex/fw.h     |  54 +++
>  drivers/net/wireless/marvell/mwifiex/init.c   |   6 +
>  drivers/net/wireless/marvell/mwifiex/ioctl.h  |   5 +
>  drivers/net/wireless/marvell/mwifiex/join.c   |  66 ++-
>  drivers/net/wireless/marvell/mwifiex/main.c   |  62 +++
>  drivers/net/wireless/marvell/mwifiex/main.h   |  17 +
>  drivers/net/wireless/marvell/mwifiex/scan.c   |   6 +
>  drivers/net/wireless/marvell/mwifiex/sdio.c   |  13 +
>  drivers/net/wireless/marvell/mwifiex/sdio.h   |   2 +
>  .../wireless/marvell/mwifiex/sta_cmdresp.c    |   2 +
>  .../net/wireless/marvell/mwifiex/sta_event.c  |  36 +-
>  .../net/wireless/marvell/mwifiex/sta_ioctl.c  |   2 +-
>  drivers/net/wireless/marvell/mwifiex/sta_tx.c |   9 +-
>  .../net/wireless/marvell/mwifiex/uap_cmd.c    | 171 ++++++++
>  drivers/net/wireless/marvell/mwifiex/util.c   | 104 +++++
>  18 files changed, 992 insertions(+), 17 deletions(-)
> 
> 
> base-commit: 347bf38330c2971230d8206eb8b37ed36b54982d
> --
> 2.34.1