Re: [PATCH 1/2] dt-bindings: iio: humidity: add ENS21x sensor family

[Krzysztof Kozlowski]

On 09/07/2024 18:36, Joshua Felmeden wrote:
> Add device tree documentation for ENS21x family of temperature and
> humidity sensors
> 
> Signed-off-by: Joshua Felmeden <jfelmeden@xxxxxxxxxxxxxxxxxxxx>


I believe that's either RESEND or v2, so you are supposed to mark it in
patch prefix accordingly. If it is v2, then provide also changelog under
--- or in cover letter.

> ---
>  .../bindings/iio/humidity/sciosense,ens21x.yaml    | 50 ++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/humidity/sciosense,ens21x.yaml b/Documentation/devicetree/bindings/iio/humidity/sciosense,ens21x.yaml
> new file mode 100644
> index 000000000000..3140349a58b8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/humidity/sciosense,ens21x.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/humidity/sciosense,ens21x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ScioSense ENS21x temperature and humidity sensor
> +
> +maintainers:
> +  - Joshua Felmeden <jfelmeden@xxxxxxxxxxxxxxxxxxxx>
> +
> +description: |
> +  Temperature and Humidity sensor.
> +
> +  Datasheet:
> +    https://www.sciosense.com/wp-content/uploads/2024/04/ENS21x-Datasheet.pdf
> +    https://www.sciosense.com/wp-content/uploads/2023/12/ENS210-Datasheet.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sciosense,ens210
> +      - sciosense,ens210a
> +      - sciosense,ens211
> +      - sciosense,ens212
> +      - sciosense,ens213a
> +      - sciosense,ens215

Driver suggests these are compatible, so I would normally expect using
one as fallback for others.

> +
> +  reg:
> +    maxItems: 1
> +

Missing supply.

> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false

This must be additionalProperties instead.

Best regards,
Krzysztof