Re: [PATCH v2] dt-bindings: crypto: ice: Document QCS9100 inline crypto engine

[Tengfei Fan]

On 7/10/2024 6:16 PM, Krzysztof Kozlowski wrote:
> On 09/07/2024 15:08, Tengfei Fan wrote:
> > Document the compatible used for the inline crypto engine found on
> > QCS9100.
> >
> > QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> > platform use non-SCMI resource. In the future, the SA8775p platform will
> > move to use SCMI resources and it will have new sa8775p-related device
> > tree. Consequently, introduce "qcom,qcs9100-inline-crypto-engine" to
> > describe non-SCMI based crypto engine.
> >
> > Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
> > ---
> > Introduce support for the QCS9100 SoC device tree (DTSI) and the
> > QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
> > While the QCS9100 platform is still in the early design stage, the
> > QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
> > mounts the QCS9100 SoC instead of the SA8775p SoC.
> >
> > The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
> > all the compatible strings will be updated from "SA8775p" to "QCS9100".
> > The QCS9100 device tree patches will be pushed after all the device tree
> > bindings and device driver patches are reviewed.
> >
> > The final dtsi will like:
> > https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@xxxxxxxxxxx/
> >   
> > The detailed cover letter reference:
> > https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@xxxxxxxxxxx/
> >
> > Co-developed-by: Maria Yu <quic_aiquny@xxxxxxxxxxx>
> > Signed-off-by: Maria Yu <quic_aiquny@xxxxxxxxxxx>
>
> This looks messy - wrongly placed, not in correct DCO order. Some tools
> will just ignore it, some might produce wrong result.
>
> Best regards,
> Krzysztof

Thanks Krzysztof!

I will fix the messy information in all the QCS9100 related patch series 
in the next.

--
Thx and BRs,
Tengfei Fan