Re: [PATCH 1/2] ASoC: dt-bindings: Add bindings for Everest ES7243E

From: Krzysztof Kozlowski
Date: Wed Jul 10 2024 - 06:38:42 EST


On 09/07/2024 12:41, Igor Prusov wrote:
> Add dt-bindings for Everest Semi ES7243E ADC.
>
> Signed-off-by: Igor Prusov <ivprusov@xxxxxxxxxxxxxxxxx>
> ---


> +required:
> + - compatible
> + - reg
> + - "#sound-dai-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + es7243e: es7243e@14 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
usually audio-codec

Best regards,
Krzysztof