Re: [PATCH v6 1/9] soc: qcom: cpr3: Fix 'acc_desc' usage

From: Konrad Dybcio
Date: Wed Jul 10 2024 - 07:05:28 EST


On 10.07.2024 8:10 AM, Varadarajan Narayanan wrote:
> cpr3 code assumes that 'acc_desc' is available for SoCs
> implementing CPR version 4 or less. However, IPQ9574 SoC
> implements CPRv4 without ACC. This causes NULL pointer accesses
> resulting in crashes. Hence, check if 'acc_desc' is populated
> before using it.
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> ---

Does it not work if you drop this patch?

In v15, drv->tcsr is left NULL (from kzalloc), unless data->acc_desc
is present

Konrad