Re: [PATCH V2] test/vsock: add install target

[Stefano Garzarella]

On Wed, Jul 10, 2024 at 08:27:28PM GMT, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
>
> Add install target for vsock to make Yocto easy to install the images.
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---

LGTM! This is a net-next material, so next time better to specify it 
(e.g. [PATCH net-next]).

If not queued within a week, please resend specifying net-next.

Reviewed-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>

> V2:
> Use VSOCK_INSTALL_PATH, drop INSTALL_PATH
>
> tools/testing/vsock/Makefile | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/tools/testing/vsock/Makefile b/tools/testing/vsock/Makefile
> index a7f56a09ca9f..6e0b4e95e230 100644
> --- a/tools/testing/vsock/Makefile
> +++ b/tools/testing/vsock/Makefile
> @@ -13,3 +13,16 @@ CFLAGS += -g -O2 -Werror -Wall -I. -I../../include -I../../../usr/include -Wno-p
> clean:
> 	${RM} *.o *.d vsock_test vsock_diag_test vsock_perf vsock_uring_test
> -include *.d
> +
> +VSOCK_INSTALL_PATH ?=
> +
> +install: all
> +ifdef VSOCK_INSTALL_PATH
> +	mkdir -p $(VSOCK_INSTALL_PATH)
> +	install -m 744 vsock_test $(VSOCK_INSTALL_PATH)
> +	install -m 744 vsock_perf $(VSOCK_INSTALL_PATH)
> +	install -m 744 vsock_diag_test $(VSOCK_INSTALL_PATH)
> +	install -m 744 vsock_uring_test $(VSOCK_INSTALL_PATH)
> +else
> +	$(error Error: set VSOCK_INSTALL_PATH to use install)
> +endif
> --
> 2.37.1