Re: [PATCH 08/13] media: qcom: camss: csiphy-3ph: Add Gen2 v1.2 two-phase MIPI CSI-2 DPHY init

From: Depeng Shao
Date: Wed Jul 10 2024 - 09:34:18 EST




On 7/10/2024 7:13 PM, Bryan O'Donoghue wrote:
On 09/07/2024 17:06, Depeng Shao wrote:
+/* GEN2 1.2 2PH */
+static const struct
+csiphy_lane_regs lane_regs_sm8550[] = {
+    {0x0E90, 0x0f, 0x00, CSIPHY_DEFAULT_PARAMS},
+    {0x0E98, 0x08, 0x00, CSIPHY_DEFAULT_PARAMS},

Definitely not DPHY 1.2 init sequence.

Could you update to something like /* GEN2 2.x - two phase 5 Gbps DPHY mode 4 lanes */

Since the PHY can be in DPHY or CPHY mode at different data-rates it would be nice to call out the exact mode we are upstreaming here.

---
bod


Yes, this isn't 1.2, it should be GEN2 2.1.2, thanks for catching this.

Thanks,
Depeng