Re: [PATCH v2 2/3] mm: Remove pud_user() from asm-generic/pgtable-nopmd.h

From: Peter Xu
Date: Wed Jul 10 2024 - 10:46:02 EST


On Wed, Jul 10, 2024 at 09:51:21AM +0200, Christophe Leroy wrote:
> Commit 2c8a81dc0cc5 ("riscv/mm: fix two page table check related
> issues") added pud_user() in include/asm-generic/pgtable-nopmd.h
>
> But pud_user() only exists on ARM64 and RISCV and is not expected
> by any part of MM.
>
> Add the missing definition in arch/riscv/include/asm/pgtable-32.h
> and remove it from asm-generic/pgtable-nopmd.h
>
> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>

I assume you double checked the riscv cross-builds on both 32/64. It looks
correct:

Reviewed-by: Peter Xu <peterx@xxxxxxxxxx>

--
Peter Xu