Re: [PATCH v6] sched: Consolidate cpufreq updates

[Dietmar Eggemann]

On 09/07/2024 09:48, Vincent Guittot wrote:
> On Wed, 19 Jun 2024 at 22:14, Qais Yousef <qyousef@xxxxxxxxxxx> wrote:

[...]

>> @@ -811,7 +818,14 @@ int __sched_setscheduler(struct task_struct *p,
>>         if (running)
>>                 set_next_task(rq, p);
>>
>> -       check_class_changed(rq, p, prev_class, oldprio);
>> +       update_cpufreq |= check_class_changed(rq, p, prev_class, oldprio);
>> +
>> +       /*
>> +        * Changing class or uclamp value implies requiring to send cpufreq
>> +        * update.
>> +        */
>> +       if (update_cpufreq && running)
> 
> Why running ? it should be queued as we are max aggregating

Also wondering ... IMHO, this has been discussed in v4 already:

https://lkml.kernel.org/r/20240529011144.smuq6dbaxvulxy4e@airbuntu

[...]