Re: [PATCH fs/bfs 1/2] bfs: fix null-ptr-deref in bfs_move_block

[Markus Elfring]

> Add a check to ensure 'sb_getblk' did not return NULL before copying data.

Wording suggestion:
                        that a sb_getblk() call


How do you think about to use a summary phrase like
“Prevent null pointer dereference in bfs_move_block()”?


…
> +++ b/fs/bfs/file.c
> @@ -35,16 +35,22 @@ static int bfs_move_block(unsigned long from, unsigned long to,
>  					struct super_block *sb)
>  {
>  	struct buffer_head *bh, *new;
> +	int err;

Can a statement (like the following) become more appropriate for such
a function implementation?

	int ret = 0;


Regards,
Markus