Re: [PATCH v5 2/7] KVM: Add KVM_PRE_FAULT_MEMORY vcpu ioctl to pre-populate guest memory

From: Anish Moorthy
Date: Wed Jul 10 2024 - 16:46:56 EST


On Wed, Jul 10, 2024 at 10:41 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> + if (!PAGE_ALIGNED(range->gpa) ||
> + !PAGE_ALIGNED(range->size) ||
> ...
> + return -EINVAL;

If 'gpa' and 'size' must be page-aligned anyways, doesn't it make
sense to just take a 'gfn' and 'num_pages' and eliminate this error
condition?