Re: [PATCH 2/2] kernel: rerun task_work while freezing in get_signal()

From: Tejun Heo
Date: Wed Jul 10 2024 - 18:01:56 EST


Hello,

On Wed, Jul 10, 2024 at 11:34:19PM +0200, Oleg Nesterov wrote:
...
> > it'd be better to freeze them together.
>
> And I tend to agree. simply beacase do_freezer_trap() (and more users of
> clear_thread_flag(TIF_SIGPENDING) + schedule(TASK_INTERRUPTIBLE) pattern)
> do not take TIF_NOTIFY_SIGNAL into account.
>
> But how do you think this patch can make the things worse wrt CRIU ?

Oh, I'm not arguing against the patch at all. Just daydreaming about what
future cleanups should look like.

...
> In short, I don't like this patch either, I just don't see a better
> solution for now ;)

I think we're on the same page.

Thanks.

--
tejun