Re: [PATCH v3 1/2] cgroup: Show # of subsystem CSSes in cgroup.stat

From: Waiman Long
Date: Wed Jul 10 2024 - 19:51:49 EST



On 7/10/24 17:59, Tejun Heo wrote:
Hello,

On Wed, Jul 10, 2024 at 02:23:52PM -0400, Waiman Long wrote:
With this patch applied, a sample output from root cgroup.stat file
was shown below.

nr_descendants 54
nr_dying_descendants 44
nr_cpuset 1
nr_cpu 40
nr_io 40
nr_memory 54
nr_dying_memory 44
nr_perf_event 55
nr_hugetlb 1
nr_pids 54
nr_rdma 1
nr_misc 1
So, css may be too specific a name but this looks a bit disorganized. How
about using controller as the common prefix? Maybe something like:

nr_controllers_cpu 40
nr_controllers_io 40
nr_controllers_memory 54
nr_controller_perf_event 55
...
nr_dying_controllers_memory 44

If controllers is too long, we can shorten it somehow or use subsys, maybe?

I think "controllers" is too long. I am fine with "subsys". Will make change in the next version.

Thanks,
Longman