Re: [PATCH v4 2/3] dt-bindings: media: mediatek: mdp: Change mediatek,gce-events to reference

[Jason-JH Lin (林睿祥)]

Hi Mauro,

Sorry for missing CC this patch to you.
Could you please take a look at this?
Thanks!

Regards,
Jason-JH.Lin

On Wed, 2024-01-24 at 09:14 +0800, Jason-JH.Lin wrote:
> Change mediatek,gce-events property to reference mediatek,gce-
> props.yaml
> instead of defining itself.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>
> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> ---
>  .../bindings/media/mediatek,mdp3-rdma.yaml           | 11 +++-------
> -
>  .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 12 ++++----
> ----
>  .../bindings/media/mediatek,mdp3-wrot.yaml           | 12 ++++----
> ----
>  3 files changed, 11 insertions(+), 24 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> index 59db8306485b..4a286d46c8ee 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> @@ -44,13 +44,6 @@ properties:
>        4 arguments defined in this property. Each GCE subsys id is
> mapping to
>        a client defined in the header include/dt-bindings/gce/<chip>-
> gce.h.
>  
> -  mediatek,gce-events:
> -    description:
> -      The event id which is mapping to the specific hardware event
> signal
> -      to gce. The event id is defined in the gce header
> -      include/dt-bindings/gce/<chip>-gce.h of each chips.
> -    $ref: /schemas/types.yaml#/definitions/uint32-array
> -
>    mediatek,scp:
>      $ref: /schemas/types.yaml#/definitions/phandle
>      description:
> @@ -96,6 +89,8 @@ required:
>    - '#dma-cells'
>  
>  allOf:
> +  - $ref: /schemas/mailbox/mediatek,gce-props.yaml
> +
>    - if:
>        properties:
>          compatible:
> @@ -142,7 +137,7 @@ allOf:
>          clocks:
>            maxItems: 1
>  
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  examples:
>    - |
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rsz.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rsz.yaml
> index f5676bec4326..4774fdde1a1b 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
> @@ -38,13 +38,6 @@ properties:
>        4 arguments defined in this property. Each GCE subsys id is
> mapping to
>        a client defined in the header include/dt-bindings/gce/<chip>-
> gce.h.
>  
> -  mediatek,gce-events:
> -    description:
> -      The event id which is mapping to the specific hardware event
> signal
> -      to gce. The event id is defined in the gce header
> -      include/dt-bindings/gce/<chip>-gce.h of each chips.
> -    $ref: /schemas/types.yaml#/definitions/uint32-array
> -
>    clocks:
>      minItems: 1
>  
> @@ -55,7 +48,10 @@ required:
>    - mediatek,gce-events
>    - clocks
>  
> -additionalProperties: false
> +allOf:
> +  - $ref: /schemas/mailbox/mediatek,gce-props.yaml
> +
> +unevaluatedProperties: false
>  
>  examples:
>    - |
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> wrot.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> wrot.yaml
> index 53a679338402..a31f3f5aea96 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
> @@ -38,13 +38,6 @@ properties:
>        4 arguments defined in this property. Each GCE subsys id is
> mapping to
>        a client defined in the header include/dt-bindings/gce/<chip>-
> gce.h.
>  
> -  mediatek,gce-events:
> -    description:
> -      The event id which is mapping to the specific hardware event
> signal
> -      to gce. The event id is defined in the gce header
> -      include/dt-bindings/gce/<chip>-gce.h of each chips.
> -    $ref: /schemas/types.yaml#/definitions/uint32-array
> -
>    power-domains:
>      maxItems: 1
>  
> @@ -67,7 +60,10 @@ required:
>    - iommus
>    - '#dma-cells'
>  
> -additionalProperties: false
> +allOf:
> +  - $ref: /schemas/mailbox/mediatek,gce-props.yaml
> +
> +unevaluatedProperties: false
>  
>  examples:
>    - |