Re: [PATCH] kernel/ext4: sanity check for NULL pointer after ext4_force_shutdown

[Theodore Ts'o]

On Wed, 03 Jul 2024 09:01:12 +0200, Wojciech Gładysz wrote:
> Test case: 2 threads write short inline data to a file.
> In ext4_page_mkwrite the resulting inline data is converted.
> Handling ext4_grp_locked_error with description "block bitmap
> and bg descriptor inconsistent: X vs Y free clusters" calls
> ext4_force_shutdown. The conversion clears
> EXT4_STATE_MAY_INLINE_DATA but fails for
> ext4_destroy_inline_data_nolock and ext4_mark_iloc_dirty due
> to ext4_forced_shutdown. The restoration of inline data fails
> for the same reason not setting EXT4_STATE_MAY_INLINE_DATA.
> Without the flag set a regular process path in ext4_da_write_end
> follows trying to dereference page folio private pointer that has
> not been set. The fix calls early return with -EIO error shall the
> pointer to private be NULL.
> 
> [...]

Applied, thanks!

[1/1] kernel/ext4: sanity check for NULL pointer after ext4_force_shutdown
      commit: 83f4414b8f84249d538905825b088ff3ae555652

Best regards,
-- 
Theodore Ts'o <tytso@xxxxxxx>