Re: [PATCH v2] Fix WARNING in __ext4_ioctl

[Theodore Ts'o]

Thanks for the patch; however, the correct fix submitted by Kees with
this commit:

commit be27cd64461c45a6088a91a04eba5cd44e1767ef
Author: Kees Cook <kees@xxxxxxxxxx>
Date:   Thu May 23 15:54:12 2024 -0700

    ext4: use memtostr_pad() for s_volume_name
    
    As with the other strings in struct ext4_super_block, s_volume_name is
    not NUL terminated. The other strings were marked in commit 072ebb3bffe6
    ("ext4: add nonstring annotations to ext4.h"). Using strscpy() isn't
    the right replacement for strncpy(); it should use memtostr_pad()
    instead.
    
    Reported-by: syzbot+50835f73143cc2905b9e@xxxxxxxxxxxxxxxxxxxxxxxxx
    Closes: https://lore.kernel.org/all/00000000000019f4c00619192c05@xxxxxxxxxx/
    Fixes: 744a56389f73 ("ext4: replace deprecated strncpy with alternatives")
    Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
    Link: https://patch.msgid.link/20240523225408.work.904-kees@xxxxxxxxxx
    Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>

						- Ted