Re: [PATCH v2 1/2] dt-bindings: phy: describe the Qualcomm SGMII PHY for QCS9100

[Tengfei Fan]

On 7/10/2024 6:13 PM, Krzysztof Kozlowski wrote:
> On 09/07/2024 17:15, Tengfei Fan wrote:
> > Document the Qualcomm SGMII PHY for the QCS9100 platforms.
> > QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> > platform use non-SCMI resource. In the future, the SA8775p platform will
> > move to use SCMI resources and it will have new sa8775p-related device
> > tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to describe
> > non-SCMI based the Qualcomm SGMII PHY.
> >
> > Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml        | 5 ++++-
> >   1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> > index b9107759b2a5..74ec4579c0d6 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> > @@ -15,7 +15,10 @@ description:
> >   
> >   properties:
> >     compatible:
> > -    const: qcom,sa8775p-dwmac-sgmii-phy
> > +    items:
>
> items is not needed here, this could be an enum directly.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Thanks Krzysztof!

In the next version patch series, I will check all the patch series, 
using an enum instead od items.

> Best regards,
> Krzysztof

--
Thx and BRs,
Tengfei Fan