Re: [PATCH v1] arm64: dts: qcom: sa8775p: Add UART node

[Krzysztof Kozlowski]

On 11/07/2024 07:04, Viken Dadhaniya wrote:
>>>> +				clock-names = "se";
>>>> +				interconnects = <&clk_virt MASTER_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS
>>>> +						 &clk_virt SLAVE_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS>,
>>>> +						<&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
>>>> +						 &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ALWAYS>;
>>>> +				interconnect-names = "qup-core", "qup-config";
>>>> +				power-domains = <&rpmhpd SA8775P_CX>;
>>>
>>> All the clocks, interconenct and power domains look to me questionable.
>>> AFAIK, most of it (if not all) is going to be removed.
>>
>> Yeah.. I'm lukewarm on accepting any sa8775p changes until that qcs9100(?)
>> situation is squared out first
>>
>> Konrad
> 
> Thanks for clarification. Please help to sign-off or let me know in case 
> of any concern.

I think I was quite explicit, so I feel above suggestion as still
pushing your choice even though to reviewers gave you their opinion.

In such case:

No, NAK, for the reasons stated above.

Best regards,
Krzysztof