Re: [PATCH] test/vsock: add install target

[Stefano Garzarella]

CCing Stefan.

On Wed, Jul 10, 2024 at 07:00:59PM GMT, Jakub Kicinski wrote:
> On Wed, 10 Jul 2024 13:58:39 +0200 Stefano Garzarella wrote:
> > There is a comment there:
> >
> >      # Avoid changing the rest of the logic here and lib.mk.
> >
> > Added by commit 17eac6c2db8b2cdfe33d40229bdda2acd86b304a.
> >
> > IIUC they re-used INSTALL_PATH, just to avoid too many changes in that
> > file and in tools/testing/selftests/lib.mk
> >
> > So, IMHO we should not care about it and only use VSOCK_INSTALL_PATH if
> > you don't want to conflict with INSTALL_PATH.
>
> Any reason why vsock isn't part of selftests in the first place?

Usually vsock tests test both the driver (virtio-vsock) in the guest and 
the device in the host kernel (vhost-vsock). So I usually run the tests 
in 2 nested VMs to test the latest changes for both the guest and the 
host.

I don't know enough selftests, but do you think it is possible to 
integrate them?

CCing Stefan who is the original author and may remember more reasons 
about this choice.

Thanks,
Stefano