Re: [PATCH v0 1/2] dt-bindings: usb: qcom,dwc3: Add minItems for interrupt info

From: Krzysztof Kozlowski
Date: Thu Jul 11 2024 - 03:47:43 EST


On 11/07/2024 08:56, Varadarajan Narayanan wrote:
> IPQ5332 has only three interrupts. Update min items
> accordingly for interrupt names to fix the following
> dt_binding_check errors.
>
> interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
>
> Fixes: a5c7592366af ("dt-bindings: usb: qcom,dwc3: add SC8280XP binding")

There is no ipq5332 at this commit, so I do not understand which bug are
you fixing.

> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> index efde47a5b145..283bac1efba9 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> @@ -432,8 +432,11 @@ allOf:
> then:
> properties:
> interrupts:
> + minItems: 3
> maxItems: 4
> interrupt-names:
> + minItems: 3
> + maxItems: 4

but x1e80100 has 4, right?

> items:
> - const: pwr_event
> - const: dp_hs_phy_irq

Best regards,
Krzysztof