[PATCH net-next] net: ethtool: Monotonically increase the message sequence number

From: Danielle Ratson
Date: Thu Jul 11 2024 - 04:10:27 EST


Currently, during the module firmware flashing process, unicast
notifications are sent from the kernel using the same sequence number,
making it impossible for user space to track missed notifications.

Monotonically increase the message sequence number, so the order of
notifications could be tracked effectively.

Signed-off-by: Danielle Ratson <danieller@xxxxxxxxxx>
Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx>
---
net/ethtool/module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ethtool/module.c b/net/ethtool/module.c
index aba78436d350..6988e07bdcd6 100644
--- a/net/ethtool/module.c
+++ b/net/ethtool/module.c
@@ -488,7 +488,7 @@ ethnl_module_fw_flash_ntf(struct net_device *dev,
if (!skb)
return;

- hdr = ethnl_unicast_put(skb, ntf_params->portid, ntf_params->seq,
+ hdr = ethnl_unicast_put(skb, ntf_params->portid, ++ntf_params->seq,
ETHTOOL_MSG_MODULE_FW_FLASH_NTF);
if (!hdr)
goto err_skb;
--
2.45.0