Re: [PATCH] drivers/clocksource/qcom: Add missing iounmap() on error when reading clock frequency.

[Konrad Dybcio]

On 11.07.2024 10:11 AM, Konrad Dybcio wrote:
> On 11.07.2024 7:49 AM, Ankit Agrawal wrote:
>> On Wed, Jul 10, 2024 at 01:54:01PM +0200, Konrad Dybcio wrote:
>>> On 10.07.2024 1:08 PM, Ankit Agrawal wrote:

[...]

> 
> Ohh right source_base is a global variable.. perhaps the original patch
> here makes more sense given we definitely don't wanna unmap that..
> 
> So I'd say let's go with this one after all
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

We should probably also check if msm_timer_init() succeeds and unmap
if that fails.. we can just check the return value of that function
and if it's non-zero, call iounmap

Konrad