Re: [PATCH v2 1/2] net: pse-pd: Do not return EOPNOSUPP if config is null

From: Simon Horman
Date: Thu Jul 11 2024 - 04:43:11 EST


On Wed, Jul 10, 2024 at 01:42:30PM +0200, Kory Maincent wrote:
> For a PSE supporting both c33 and PoDL, setting config for one type of PoE
> leaves the other type's config null. Currently, this case returns
> EOPNOTSUPP, which is incorrect. Instead, we should do nothing if the
> configuration is empty.
>
> Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> Fixes: d83e13761d5b ("net: pse-pd: Use regulator framework within PSE framework")
> ---
>
> Changes in v2:
> - New patch to fix dealing with a null config.

Hi Kory,

A few thing from a process perspective:

1. As fixes, with fixes tags (good!), this patchset seems like it is
appropriate for net rather than net-next. And indeed it applies
to net but not net-next. However, the absence of a target tree
confuses our CI which failed to apply the patchset to net-next.

Probably this means it should be reposted, targeted at net.

Subject: [Patch v3 net x/y] ...

See: https://docs.kernel.org/process/maintainer-netdev.html

2. Please provide a cover letter for patch sets with more than one
(but not just one) patch. That provides an overview of how
the patches relate to each other. And a convenient anchor for
feedback such as point 1 above.

...