Re: [PATCH 1/2] media: ov5675: Derive delay cycles from the clock rate reported

[Quentin Schulz]

Hi Bryan,

On 7/11/24 12:20 PM, Bryan O'Donoghue wrote:
> The ov5675 driver expresses its reset delays in terms of XVCLK cycles as
> per the ov5675 specification. XVCLK can be anything in the range of 6 MHz
> to 24 MHz inclusive.
>
> Upstream we use 19.2 MHz however, since the delays are calculated in terms
> of clock cycles as opposed to fixed intervals it makes sense to facilitate
> any potential clock we might support.
>
> Do so by reading the XVCLK rate and using the returned rate instead of
> operating from a static definition.

We're actually running this sensor at **almost** 19.2MHz but are having 
intermittent issues, so this could probably help us too. In the end (for 
my employer), we should just add support for 24MHz as that's a frequency 
our products support but I'm lacking time right now. One day hopefully.

> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

The change isn't really useful for upstream yet but makes sense to me, so:

Reviewed-by: Quentin Schulz <quentin.schulz@xxxxxxxxx>

Thanks!
Quentin