Re: [PATCH 2/4] Bluetooth: hci_uart: Add support for Amlogic HCI UART

[Yang Li]

On 2024/7/7 21:10, Krzysztof Kozlowski wrote:
> [Some people who received this message don't often get email from krzk@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
>
> On 05/07/2024 13:20, Yang Li via B4 Relay wrote:
> > From: Yang Li <yang.li@xxxxxxxxxxx>
> >
> > This patch introduces support for Amlogic Bluetooth controller over
> > UART. In order to send the final firmware at full speed. It is a pretty
> > straight forward H4 driver with exception of actually having it's own
> > setup address configuration.
> >
> > Co-developed-by: Ye He <ye.he@xxxxxxxxxxx>
> Read submitting patches. Missing SoB.
Will do.
> > Signed-off-by: Yang Li <yang.li@xxxxxxxxxxx>
> > ---
> >   drivers/bluetooth/Kconfig     |  13 +
>
>
> > +
> > +static void aml_serdev_remove(struct serdev_device *serdev)
> > +{
> > +     struct aml_serdev *amldev = serdev_device_get_drvdata(serdev);
> > +
> > +     hci_uart_unregister_device(&amldev->serdev_hu);
> > +}
> > +
> > +static const struct aml_device_data data_w155s2 __maybe_unused = {
> > +     .iccm_offset = 256 * 1024,
> > +};
> > +
> > +static const struct aml_device_data data_w265s2 __maybe_unused = {
> How this can be "maybe_unused" while it is referenced always? This is
> buggy. Either everything in OF chain can be unused or not. Not half yes,
> half not.
well, i will remove __maybe_unused.
> > +     .iccm_offset = 384 * 1024,
> > +};
> > +
> > +static const struct of_device_id aml_bluetooth_of_match[] = {
> > +     { .compatible = "amlogic,w155s2-bt", .data = &data_w155s2 },
> > +     { .compatible = "amlogic,w265s2-bt", .data = &data_w265s2 },
> > +     { /* sentinel */ },
> > +};
> > +
> > +static struct serdev_device_driver aml_serdev_driver = {
> > +     .probe = aml_serdev_probe,
> > +     .remove = aml_serdev_remove,
> > +     .driver = {
> > +             .name = "hci_uart_aml",
> > +             .of_match_table = of_match_ptr(aml_bluetooth_of_match),
> So now you have warnings... drop of_match_ptr.
Will do.
> Best regards,
> Krzysztof