Re: [PATCH v4 07/16] x86/cpu: Defer CR pinning setup until after EFI initialization

From: Kirill A. Shutemov
Date: Thu Jul 11 2024 - 06:37:25 EST


On Thu, Jul 11, 2024 at 10:11:53AM +0200, Peter Zijlstra wrote:
> On Wed, Jul 10, 2024 at 07:06:43PM +0300, Alexander Shishkin wrote:
> > In order to map the EFI runtime services, set_virtual_address_map
> > needs to be called, which resides in the lower half of the address
> > space. This means that LASS needs to be temporarily disabled around
> > this call. This can only be done before the CR pinning is set up.
> >
> > Move CR pinning setup behind the EFI initialization.
> >
> > Signed-off-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
> > Suggested-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
>
> So the previous patch makes us not boot, and this fixes it up? Perhaps
> order things differently?

Maybe just move LASS enabling (patch 04/16) to the very end of the
patchset?

--
Kiryl Shutsemau / Kirill A. Shutemov