Re: [PATCH v3 2/2] leds: leds-pca995x: Add support for NXP PCA9956B

[Marek Vasut]

On 7/11/24 9:52 AM, Pieterjan Camerlynck via B4 Relay wrote:

[...]

> @@ -52,9 +69,9 @@ struct pca995x_led {
>   };
>   
>   struct pca995x_chip {
> +	const struct pca995x_chipdef *chipdef;
>   	struct regmap *regmap;
>   	struct pca995x_led leds[PCA995X_MAX_OUTPUTS];
> -	int btype;

Nitpick, maybe you can replace btype with chipdef in this place, without 
reordering the structure ?

>   };
>   
>   static int pca995x_brightness_set(struct led_classdev *led_cdev,

In any case:

Reviewed-by: Marek Vasut <marex@xxxxxxx>

Thanks !