Re: [RFC V3 2/4] firmware: arm_scmi: vendors: Add ARM SCMI QCOM vendor protocol v1.0

[Sibi Sankar]

On 7/9/24 15:40, Konrad Dybcio wrote:
> On 2.07.2024 9:14 PM, Sibi Sankar wrote:
> > The ARM SCMI QCOM vendor protocol provides a generic way of exposing a
> > number of Qualcomm SoC specific features (like memory bus scaling) through
> > a mixture of pre-determined algorithm strings and param_id pairs hosted on
> > the SCMI controller.
>
> [...]

Hey Konrad,

Thanks for taking time to review the series.

> > +/**
> > + * qcom_scmi_vendor_protocol_cmd - vendor specific commands supported by Qualcomm SCMI
> > + *                                 vendor protocol.
>
> include the word 'enum' or:
>
> warning: cannot understand function prototype: 'enum qcom_scmi_vendor_protocol_cmd '

will fix it in the next re-spin.

-Sibi

> Konrad