Re: [PATCH v1 0/2] PCI: ti: k3: Fix TI J721E PERST# polarity

[Niklas Cassel]

On Wed, Jul 03, 2024 at 12:00:34PM +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> 
> Fix PCIe PERST# signal polarity in TI J721E used on TI K3 machines.
> 
> PCIe PERST# needs to be de-asserted for PCIe to work, however, the driver is
> doing the opposite and the device tree files are defining the signal with the
> wrong polarity to cope with that. Fix both the driver and the affected DT
> files.

Hello there,

While I understand why you want to fix this,
I'm not sure if you can actually do so without breaking device tree backwards
compatibility.

Imagine e.g. a board that has the DTB in ROM.
The user upgrades the kernel, and the DTB that was working with the old
kernel will now no longer work with the new kernel (because of your driver
change).

Just because you update the DTS files, you cannot assume that all DTBs
out there in the wild will automatically be updated.

That is what the DT maintainers told me many years ago when I wanted to do a
similar change as yours, for another PCIe controller driver.

Perhaps you could add a comment in the driver and the DTS files explaining
that the DTS is actually wrong, but cannot be changed because of DT backwards
compatibility.


Kind regards,
Niklas