Re: [PATCH] fs/affs: struct slink_front: Replace 1-element array with flexible array

From: David Sterba
Date: Thu Jul 11 2024 - 10:29:55 EST


On Wed, Jul 10, 2024 at 03:57:34PM -0700, Kees Cook wrote:
> Replace the deprecated[1] use of a 1-element array in
> struct slink_front with a modern flexible array.
>
> No binary differences are present after this conversion.
>
> Link: https://github.com/KSPP/linux/issues/79 [1]
> Signed-off-by: Kees Cook <kees@xxxxxxxxxx>

Thanks, I've added the 3 patches to my tree. I've noticed there's one
more 1-element array in struct affs_root_head (hashtable):

https://elixir.bootlin.com/linux/latest/source/fs/affs/amigaffs.h#L50

The struct is used only partially by AFFS_ROOT_HEAD from affs_fill_super
and not accessing the hashtable. This could have been missed by the
tools you use or was the conversion intentionally skipped?