Re: [PATCH net-next v16 12/13] selftests: add ncdevmem, netcat for devmem TCP

[Mina Almasry]

On Wed, Jul 10, 2024 at 5:44 PM John Hubbard <jhubbard@xxxxxxxxxx> wrote:
>
> On 7/9/24 5:17 PM, Mina Almasry wrote:
> ...
> > diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> > index bc3925200637c..39420a6e86b7f 100644
> > --- a/tools/testing/selftests/net/Makefile
> > +++ b/tools/testing/selftests/net/Makefile
> > @@ -95,6 +95,11 @@ TEST_PROGS += fq_band_pktlimit.sh
> >   TEST_PROGS += vlan_hw_filter.sh
> >   TEST_PROGS += bpf_offload.py
> >
> > +# YNL files, must be before "include ..lib.mk"
> > +EXTRA_CLEAN += $(OUTPUT)/libynl.a
> > +YNL_GEN_FILES := ncdevmem
> > +TEST_GEN_FILES += $(YNL_GEN_FILES)
> > +
> >   TEST_FILES := settings
> >   TEST_FILES += in_netns.sh lib.sh net_helper.sh setup_loopback.sh setup_veth.sh
> >
> > @@ -104,6 +109,10 @@ TEST_INCLUDES := forwarding/lib.sh
> >
> >   include ../lib.mk
> >
> > +# YNL build
> > +YNL_GENS := netdev
> > +include ynl.mk
>
> This seems to be missing a rule to generate ynl.mk, right?
>

Hi John,

tools/testing/selftests/net/ynl.mk was merged as part of this patch a
few days ago:

https://patchwork.kernel.org/project/netdevbpf/patch/20240628003253.1694510-14-almasrymina@xxxxxxxxxx/

Is it not working for you by any chance?

-- 
Thanks,
Mina